base/base.gyp - Issue 2111613002: Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 2111613002: Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build error Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index ecc3384f20cbdc5c52cd171fb0ef2282b84268bf..7e98715e46656c4a484c42610345601b874190b0 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -407,7 +407,7 @@

'deferred_sequenced_task_runner_unittest.cc',

'environment_unittest.cc',

'feature_list_unittest.cc',

- 'file_version_info_unittest.cc',

+ 'file_version_info_win_unittest.cc',

'files/dir_reader_posix_unittest.cc',

'files/file_locking_unittest.cc',

'files/file_path_unittest.cc',

@@ -684,9 +684,6 @@

'defines': [

'USE_SYMBOLIZE',

- 'sources!': [

- 'file_version_info_unittest.cc',

- ],

'conditions': [

[ 'desktop_linux==1', {

'sources': [

« no previous file with comments | « base/BUILD.gn ('k') | base/file_version_info_unittest.cc » ('j') | no next file with comments »