Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 2111613002: Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() Currently, base::FileVersionInfo::CreateFileVersionInfoForModule() calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader lock and potentially touches the disk to obtain the VS_VERSION_INFO of the module. This is gratuitous for a module that is already loaded. With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule() uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO resource from memory. First version of this CL: https://codereview.chromium.org/2046583002/ TBR=thestig@chromium.org BUG=609709 Committed: https://crrev.com/5b7de9e98e0ec2dab0715758d2d5f5d00158a7c0 Cr-Commit-Position: refs/heads/master@{#402985}

Patch Set 1 : identical to https://codereview.chromium.org/2046583002/ #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -259 lines) Patch
M base/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M base/base.gyp View 2 chunks +1 line, -4 lines 0 comments Download
D base/file_version_info_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M base/file_version_info_win.h View 2 chunks +22 lines, -8 lines 0 comments Download
M base/file_version_info_win.cc View 1 4 chunks +73 lines, -48 lines 0 comments Download
A + base/file_version_info_win_unittest.cc View 4 chunks +74 lines, -42 lines 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
fdoray
thestig@: PTAL. This is identical to https://codereview.chromium.org/2046583002/ % a fix for the Win x64 build.
4 years ago (2016-06-29 18:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111613002/20001
4 years ago (2016-06-29 18:30:42 UTC) #5
Lei Zhang
lgtm
4 years ago (2016-06-29 18:31:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/247794)
4 years ago (2016-06-29 19:35:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111613002/20001
4 years ago (2016-06-29 21:49:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-06-29 23:13:32 UTC) #12
commit-bot: I haz the power
4 years ago (2016-06-29 23:16:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b7de9e98e0ec2dab0715758d2d5f5d00158a7c0
Cr-Commit-Position: refs/heads/master@{#402985}

Powered by Google App Engine
This is Rietveld 408576698