Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2111453002: [mojo-edk] Duplicate process handle and take ownership in NodeChannel. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Duplicate process handle and take ownership in NodeChannel. BUG=604282 Committed: https://crrev.com/1c5539e57880bf895c0169d9d2469bb9a0a001dd Cr-Commit-Position: refs/heads/master@{#402998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M mojo/edk/system/node_channel.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/edk/system/node_channel.cc View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/edk/system/node_controller.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Anand Mistry (off Chromium)
I'm pretty sure we have a handle leak when the broker is being used, and ...
4 years, 5 months ago (2016-06-29 04:25:53 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-06-29 15:33:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111453002/1
4 years, 5 months ago (2016-06-29 23:28:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 23:41:07 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 23:43:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c5539e57880bf895c0169d9d2469bb9a0a001dd
Cr-Commit-Position: refs/heads/master@{#402998}

Powered by Google App Engine
This is Rietveld 408576698