[mojo-edk] Duplicate process handle and take ownership in NodeChannel.

mojo/edk/system/node_channel.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/node_channel.h"
 
 #include <cstring>
 #include <limits>
 #include <sstream>
 
@@ skipping 205 matching lines @@
 }
 
 void NodeChannel::NotifyBadMessage(const std::string& error) {
   if (!process_error_callback_.is_null())
     process_error_callback_.Run("Received bad user message: " + error);
 }
 
 void NodeChannel::SetRemoteProcessHandle(base::ProcessHandle process_handle) {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
   base::AutoLock lock(remote_process_handle_lock_);
+  DCHECK_EQ(base::kNullProcessHandle, remote_process_handle_);
   CHECK_NE(remote_process_handle_, base::GetCurrentProcessHandle());
   remote_process_handle_ = process_handle;
+#if defined(OS_WIN)
+  DCHECK(!scoped_remote_process_handle_.is_valid());
+  scoped_remote_process_handle_.reset(PlatformHandle(process_handle));
+#endif
 }
 
 bool NodeChannel::HasRemoteProcessHandle() {
   base::AutoLock lock(remote_process_handle_lock_);
   return remote_process_handle_ != base::kNullProcessHandle;
 }
 
 base::ProcessHandle NodeChannel::CopyRemoteProcessHandle() {
   base::AutoLock lock(remote_process_handle_lock_);
 #if defined(OS_WIN)
   if (remote_process_handle_ != base::kNullProcessHandle) {
     // Privileged nodes use this to pass their childrens' process handles to the
     // broker on launch.
     HANDLE handle = remote_process_handle_;
     BOOL result = DuplicateHandle(
         base::GetCurrentProcessHandle(), remote_process_handle_,
         base::GetCurrentProcessHandle(), &handle, 0, FALSE,
         DUPLICATE_SAME_ACCESS);
-    DCHECK(result);
+    DPCHECK(result);
     return handle;
   }
   return base::kNullProcessHandle;
 #else
   return remote_process_handle_;
 #endif
 }
 
 void NodeChannel::SetRemoteNodeName(const ports::NodeName& name) {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
@@ skipping 604 matching lines @@
 
   base::AutoLock lock(channel_lock_);
   if (!channel_)
     DLOG(ERROR) << "Dropping message on closed channel.";
   else
     channel_->Write(std::move(message));
 }
 
 }  // namespace edk
 }  // namespace mojo