Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: mojo/edk/system/node_channel.h

Issue 2111453002: [mojo-edk] Duplicate process handle and take ownership in NodeChannel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/system/node_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/node_channel.h
diff --git a/mojo/edk/system/node_channel.h b/mojo/edk/system/node_channel.h
index a7d0b10c55cb409c697b9d2cd2ca4bb108ac41e9..658553c60022a06279e477e045572c4c1febf268 100644
--- a/mojo/edk/system/node_channel.h
+++ b/mojo/edk/system/node_channel.h
@@ -109,6 +109,7 @@ class NodeChannel : public base::RefCountedThreadSafe<NodeChannel>,
// Invokes the bad message callback for this channel, if any.
void NotifyBadMessage(const std::string& error);
+ // Note: On Windows, we take ownership of the remote process handle.
void SetRemoteProcessHandle(base::ProcessHandle process_handle);
bool HasRemoteProcessHandle();
// Note: The returned |ProcessHandle| is owned by the caller and should be
@@ -191,6 +192,9 @@ class NodeChannel : public base::RefCountedThreadSafe<NodeChannel>,
base::Lock remote_process_handle_lock_;
base::ProcessHandle remote_process_handle_ = base::kNullProcessHandle;
+#if defined(OS_WIN)
+ ScopedPlatformHandle scoped_remote_process_handle_;
+#endif
#if defined(OS_MACOSX) && !defined(OS_IOS)
base::Lock pending_mach_messages_lock_;
« no previous file with comments | « no previous file | mojo/edk/system/node_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698