Remove "master." when getting master name in rietveld.py.

Remove "master." when getting master name in rietveld.py.

Sometimes when fetching try job results from Rietveld, the master name
is prefixed with "master.".

BUG=474273
Committed: https://crrev.com/172edc20886f5dc2e2bc92ad255e6c60bd1e5de2
Cr-Commit-Position: refs/heads/master@{#403012}

[qyearsley, 2016-06-29 18:23:07]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, wkorman@chromium.org

[wkorman, 2016-06-29 18:31:52]

lgtm

https://codereview.chromium.org/2110833004/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py (right):

https://codereview.chromium.org/2110833004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py:46: # We want
to normalize master name by stripping this prefix.
It seems wacky that it's configured this way. Perhaps worth filing a bug for
chrome-infra to look into to standardize, with whatever examples you've seen and
a link to this change so they can see the hack workaround we've had to do.

[qyearsley, 2016-06-29 20:51:07]

https://codereview.chromium.org/2110833004/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py (right):

https://codereview.chromium.org/2110833004/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py:46: # We want
to normalize master name by stripping this prefix.
On 2016/06/29 at 18:31:52, wkorman wrote:
> It seems wacky that it's configured this way. Perhaps worth filing a bug for
chrome-infra to look into to standardize, with whatever examples you've seen and
a link to this change so they can see the hack workaround we've had to do.

Great idea. I hypothesize that when jobs are started via `git cl try`, the
master name is one way, and if started via Rietveld directly it may be another
way. If I can reproduce this then I'll file a bug for chrome-infra.

[qyearsley, 2016-06-29 21:40:39]

On 2016/06/29 at 20:51:07, qyearsley wrote:
>
https://codereview.chromium.org/2110833004/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py (right):
> 
>
https://codereview.chromium.org/2110833004/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py:46: # We want
to normalize master name by stripping this prefix.
> On 2016/06/29 at 18:31:52, wkorman wrote:
> > It seems wacky that it's configured this way. Perhaps worth filing a bug for
chrome-infra to look into to standardize, with whatever examples you've seen and
a link to this change so they can see the hack workaround we've had to do.
> 
> Great idea. I hypothesize that when jobs are started via `git cl try`, the
master name is one way, and if started via Rietveld directly it may be another
way. If I can reproduce this then I'll file a bug for chrome-infra.

Filed bug http://crbug.com/624545 for this issue and added a comment to the
code.

[qyearsley, 2016-06-29 21:40:56]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-29 21:40:57]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2110833004/#ps20001
(title: "Add bug link in code.")

[commit-bot: I haz the power, 2016-06-29 21:49:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-06-29 22:09:40]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-29 22:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2110833004/#ps60001
(title: "Updated test")

[commit-bot: I haz the power, 2016-06-29 22:15:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:16:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-30 00:18:56]

Description was changed from

==========
Remove "master." when getting master name in rietveld.py.

Sometimes when fetching try job results from Rietveld, the master name
is prefixed with "master.".

BUG=474273
==========

to

==========
Remove "master." when getting master name in rietveld.py.

Sometimes when fetching try job results from Rietveld, the master name
is prefixed with "master.".

BUG=474273

Committed: https://crrev.com/172edc20886f5dc2e2bc92ad255e6c60bd1e5de2
Cr-Commit-Position: refs/heads/master@{#403012}
==========

[commit-bot: I haz the power, 2016-06-30 00:18:57]

Patchset 4 (id:??) landed as
https://crrev.com/172edc20886f5dc2e2bc92ad255e6c60bd1e5de2
Cr-Commit-Position: refs/heads/master@{#403012}