Remove "master." when getting master name in rietveld.py.

third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions to communicate with Rietveld."""
 
 import collections
 import json
 import logging
 import urllib2
@@ skipping 24 matching lines @@
             url = _patchset_url(issue_number, patchset_number)
         else:
             url = _latest_patchset_url(issue_number, web)
         patchset_data = _get_json(url, web)
     except (urllib2.URLError, ValueError):
         return []
     jobs = []
     for job in patchset_data['try_job_results']:
         if job['builder'] not in builder_names:
             continue
+        # The master name may be prefixed with "master.", or possibly not;
+        # We want to normalize master name by stripping this prefix.

[wkorman, 2016/06/29 18:31:52]

It seems wacky that it's configured this way. Perhaps worth filing a bug for
chrome-infra to look into to standardize, with whatever examples you've seen and
a link to this change so they can see the hack workaround we've had to do.

[qyearsley, 2016/06/29 20:51:07]

Great idea. I hypothesize that when jobs are started via `git cl try`, the
master name is one way, and if started via Rietveld directly it may be another
way. If I can reproduce this then I'll file a bug for chrome-infra.

+        master_name = job['master']
+        if master_name.startswith('master.'):
+            master_name = master_name[len('master.'):]
         jobs.append(TryJob(
             builder_name=job['builder'],
-            master_name=job['master'],
+            master_name=master_name,
             build_number=job['buildnumber']))
     return jobs
 
 
 def _latest_patchset_url(issue_number, web):
     issue_data = _get_json(_issue_url(issue_number), web)
     latest_patchset_number = issue_data["patchsets"][-1]
     return _patchset_url(issue_number, latest_patchset_number)
 
 
@@ skipping 15 matching lines @@
         _log.error('Invalid JSON: %s' % contents)
         raise
 
 
 def _issue_url(issue_number):
     return '%s/%s' % (BASE_CODEREVIEW_URL, issue_number)
 
 
 def _patchset_url(issue_number, patchset_number):
     return '%s/%s' % (_issue_url(issue_number), patchset_number)