Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

Issue 2110833004: Remove "master." when getting master name in rietveld.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Utility functions to communicate with Rietveld.""" 5 """Utility functions to communicate with Rietveld."""
6 6
7 import collections 7 import collections
8 import json 8 import json
9 import logging 9 import logging
10 import urllib2 10 import urllib2
(...skipping 23 matching lines...) Expand all
34 url = _patchset_url(issue_number, patchset_number) 34 url = _patchset_url(issue_number, patchset_number)
35 else: 35 else:
36 url = _latest_patchset_url(issue_number, web) 36 url = _latest_patchset_url(issue_number, web)
37 patchset_data = _get_json(url, web) 37 patchset_data = _get_json(url, web)
38 except (urllib2.URLError, ValueError): 38 except (urllib2.URLError, ValueError):
39 return [] 39 return []
40 jobs = [] 40 jobs = []
41 for job in patchset_data['try_job_results']: 41 for job in patchset_data['try_job_results']:
42 if job['builder'] not in builder_names: 42 if job['builder'] not in builder_names:
43 continue 43 continue
44 # The master name may be prefixed with "master.", or possibly not;
45 # We want to normalize master name by stripping this prefix.
46 # See http://crbug.com/624545.
47 master_name = job['master']
48 if master_name.startswith('master.'):
49 master_name = master_name[len('master.'):]
44 jobs.append(TryJob( 50 jobs.append(TryJob(
45 builder_name=job['builder'], 51 builder_name=job['builder'],
46 master_name=job['master'], 52 master_name=master_name,
47 build_number=job['buildnumber'])) 53 build_number=job['buildnumber']))
48 return jobs 54 return jobs
49 55
50 56
51 def _latest_patchset_url(issue_number, web): 57 def _latest_patchset_url(issue_number, web):
52 issue_data = _get_json(_issue_url(issue_number), web) 58 issue_data = _get_json(_issue_url(issue_number), web)
53 latest_patchset_number = issue_data["patchsets"][-1] 59 latest_patchset_number = issue_data["patchsets"][-1]
54 return _patchset_url(issue_number, latest_patchset_number) 60 return _patchset_url(issue_number, latest_patchset_number)
55 61
56 62
(...skipping 24 matching lines...) Expand all
81 return '%s/%s' % (_issue_url(issue_number), patchset_number) 87 return '%s/%s' % (_issue_url(issue_number), patchset_number)
82 88
83 89
84 def get_latest_try_job_results(issue_number, web): 90 def get_latest_try_job_results(issue_number, web):
85 url = _latest_patchset_url(issue_number, web) 91 url = _latest_patchset_url(issue_number, web)
86 patchset_data = _get_json(url, web) 92 patchset_data = _get_json(url, web)
87 results = {} 93 results = {}
88 for job in patchset_data['try_job_results']: 94 for job in patchset_data['try_job_results']:
89 results[job['builder']] = job['result'] 95 results[job['builder']] = job['result']
90 return results 96 return results
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698