Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: cc/trees/draw_property_utils.cc

Issue 2110683004: cc: Move filters to the effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/damage_tracker_unittest.cc ('k') | cc/trees/effect_node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/draw_property_utils.cc
diff --git a/cc/trees/draw_property_utils.cc b/cc/trees/draw_property_utils.cc
index 553a0d98db2a07f2088a49ef414c3fd52aaef13c..4a79c9df6606a8dd2db3967cc2d2baee3b80a060 100644
--- a/cc/trees/draw_property_utils.cc
+++ b/cc/trees/draw_property_utils.cc
@@ -42,7 +42,6 @@ static void ValidateRenderSurfaceForLayer(LayerImpl* layer) {
if (layer->has_render_surface())
return;
- DCHECK(layer->filters().IsEmpty()) << "layer: " << layer->id();
DCHECK(!IsRootLayer(layer)) << "layer: " << layer->id();
EffectNode* effect_node =
layer->layer_tree_impl()->property_trees()->effect_tree.Node(
@@ -51,6 +50,7 @@ static void ValidateRenderSurfaceForLayer(LayerImpl* layer) {
return;
DCHECK_EQ(effect_node->mask_layer_id, -1) << "layer: " << layer->id();
DCHECK_EQ(effect_node->replica_layer_id, -1) << "layer: " << layer->id();
+ DCHECK(effect_node->filters.IsEmpty());
DCHECK(effect_node->background_filters.IsEmpty());
}
« no previous file with comments | « cc/trees/damage_tracker_unittest.cc ('k') | cc/trees/effect_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698