Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: cc/trees/damage_tracker_unittest.cc

Issue 2110683004: cc: Move filters to the effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/animation_timelines_test_common.cc ('k') | cc/trees/draw_property_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/damage_tracker_unittest.cc
diff --git a/cc/trees/damage_tracker_unittest.cc b/cc/trees/damage_tracker_unittest.cc
index 5a2008605a71f5bad2b9de208439d5e26b4111c6..b73f2bad4d98cde47fc9f17a01df139f1adb0050 100644
--- a/cc/trees/damage_tracker_unittest.cc
+++ b/cc/trees/damage_tracker_unittest.cc
@@ -67,9 +67,8 @@ void EmulateDrawingOneFrame(LayerImpl* root) {
target_surface->damage_tracker()->UpdateDamageTrackingState(
target_surface->layer_list(), target_surface,
target_surface->SurfacePropertyChangedOnlyFromDescendant(),
- target_surface->content_rect(),
- render_surface_layer_list[index]->render_surface()->MaskLayer(),
- render_surface_layer_list[index]->filters());
+ target_surface->content_rect(), target_surface->MaskLayer(),
+ target_surface->Filters());
}
root->layer_tree_impl()->ResetAllChangeTracking();
@@ -542,7 +541,7 @@ TEST_F(DamageTrackerTest, VerifyDamageForBlurredSurface) {
// Setting the filter will damage the whole surface.
ClearDamageForAllSurfaces(root);
- surface->SetFilters(filters);
+ surface->test_properties()->filters = filters;
root->layer_tree_impl()->property_trees()->needs_rebuild = true;
EmulateDrawingOneFrame(root);
@@ -594,7 +593,6 @@ TEST_F(DamageTrackerTest, VerifyDamageForImageFilter) {
// CASE 1: Setting the update rect should damage the whole surface (for now)
ClearDamageForAllSurfaces(root);
child->SetUpdateRect(gfx::Rect(1, 1));
- root->layer_tree_impl()->property_trees()->needs_rebuild = true;
EmulateDrawingOneFrame(root);
root_damage_rect =
@@ -651,7 +649,6 @@ TEST_F(DamageTrackerTest, VerifyDamageForTransformedImageFilter) {
// Setting the update rect should damage the whole surface (for now)
ClearDamageForAllSurfaces(root);
child->SetUpdateRect(gfx::Rect(30, 30));
- root->layer_tree_impl()->property_trees()->needs_rebuild = true;
EmulateDrawingOneFrame(root);
root_damage_rect =
« no previous file with comments | « cc/test/animation_timelines_test_common.cc ('k') | cc/trees/draw_property_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698