Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Side by Side Diff: cc/trees/draw_property_utils.cc

Issue 2110683004: cc: Move filters to the effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/damage_tracker_unittest.cc ('k') | cc/trees/effect_node.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/draw_property_utils.h" 5 #include "cc/trees/draw_property_utils.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 24 matching lines...) Expand all
35 return layer->layer_tree_impl()->IsRootLayer(layer); 35 return layer->layer_tree_impl()->IsRootLayer(layer);
36 } 36 }
37 37
38 #if DCHECK_IS_ON() 38 #if DCHECK_IS_ON()
39 static void ValidateRenderSurfaceForLayer(LayerImpl* layer) { 39 static void ValidateRenderSurfaceForLayer(LayerImpl* layer) {
40 // This test verifies that there are no cases where a LayerImpl needs 40 // This test verifies that there are no cases where a LayerImpl needs
41 // a render surface, but doesn't have one. 41 // a render surface, but doesn't have one.
42 if (layer->has_render_surface()) 42 if (layer->has_render_surface())
43 return; 43 return;
44 44
45 DCHECK(layer->filters().IsEmpty()) << "layer: " << layer->id();
46 DCHECK(!IsRootLayer(layer)) << "layer: " << layer->id(); 45 DCHECK(!IsRootLayer(layer)) << "layer: " << layer->id();
47 EffectNode* effect_node = 46 EffectNode* effect_node =
48 layer->layer_tree_impl()->property_trees()->effect_tree.Node( 47 layer->layer_tree_impl()->property_trees()->effect_tree.Node(
49 layer->effect_tree_index()); 48 layer->effect_tree_index());
50 if (effect_node->owner_id != layer->id()) 49 if (effect_node->owner_id != layer->id())
51 return; 50 return;
52 DCHECK_EQ(effect_node->mask_layer_id, -1) << "layer: " << layer->id(); 51 DCHECK_EQ(effect_node->mask_layer_id, -1) << "layer: " << layer->id();
53 DCHECK_EQ(effect_node->replica_layer_id, -1) << "layer: " << layer->id(); 52 DCHECK_EQ(effect_node->replica_layer_id, -1) << "layer: " << layer->id();
53 DCHECK(effect_node->filters.IsEmpty());
54 DCHECK(effect_node->background_filters.IsEmpty()); 54 DCHECK(effect_node->background_filters.IsEmpty());
55 } 55 }
56 56
57 void VerifySurfaceContentsScalesMatch(const int target_effect_id, 57 void VerifySurfaceContentsScalesMatch(const int target_effect_id,
58 const int target_transform_id, 58 const int target_transform_id,
59 const EffectTree& effect_tree, 59 const EffectTree& effect_tree,
60 const TransformTree& transform_tree) { 60 const TransformTree& transform_tree) {
61 const TransformNode* target_transform_node = 61 const TransformNode* target_transform_node =
62 transform_tree.Node(target_transform_id); 62 transform_tree.Node(target_transform_id);
63 const EffectNode* target_effect_node = effect_tree.Node(target_effect_id); 63 const EffectNode* target_effect_node = effect_tree.Node(target_effect_id);
(...skipping 1505 matching lines...) Expand 10 before | Expand all | Expand 10 after
1569 void UpdateElasticOverscroll(PropertyTrees* property_trees, 1569 void UpdateElasticOverscroll(PropertyTrees* property_trees,
1570 const Layer* overscroll_elasticity_layer, 1570 const Layer* overscroll_elasticity_layer,
1571 const gfx::Vector2dF& elastic_overscroll) { 1571 const gfx::Vector2dF& elastic_overscroll) {
1572 UpdateElasticOverscrollInternal(property_trees, overscroll_elasticity_layer, 1572 UpdateElasticOverscrollInternal(property_trees, overscroll_elasticity_layer,
1573 elastic_overscroll); 1573 elastic_overscroll);
1574 } 1574 }
1575 1575
1576 } // namespace draw_property_utils 1576 } // namespace draw_property_utils
1577 1577
1578 } // namespace cc 1578 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/damage_tracker_unittest.cc ('k') | cc/trees/effect_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698