Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.cc
diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc
index ca8413a432ef4f842d226054c8e7c8ef5980355e..b6bc189eec39b2c2afac8111cf456f2d893bfc8d 100644
--- a/components/autofill/core/browser/personal_data_manager.cc
+++ b/components/autofill/core/browser/personal_data_manager.cc
@@ -591,7 +591,7 @@ void PersonalDataManager::UpdateServerCreditCard(
// Look up by server id, not GUID.
CreditCard* existing_credit_card = nullptr;
- for (auto it : server_credit_cards_) {
+ for (auto* it : server_credit_cards_) {
vabr (Chromium) 2016/07/19 07:54:09 optional nit: Could we rename |it| to |server_card
vabr (Chromium) 2016/07/19 07:54:09 optional: Could we make this "const auto*" and cha
vmpstr 2016/07/19 19:49:31 Done.
if (credit_card.server_id() == it->server_id()) {
existing_credit_card = it;
break;
@@ -620,7 +620,7 @@ void PersonalDataManager::UpdateServerCardBillingAddress(
return;
CreditCard* existing_credit_card = nullptr;
- for (auto it : server_credit_cards_) {
+ for (auto* it : server_credit_cards_) {
if (credit_card.guid() == it->guid()) {
existing_credit_card = it;
break;

Powered by Google App Engine
This is Rietveld 408576698