components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/personal_data_manager.cc ('K') | « components/autofill/core/browser/personal_data_manager.cc ('k') | components/bookmarks/managed/managed_bookmark_service.cc » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

index cd99e11a2aadc10c9926a21498dea92aa64ca4f1..d894a6873578d81739e10db380ae50fbeaa8c6e3 100644

--- a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

@@ -111,7 +111,7 @@ AutofillProfileSyncableService::MergeDataAndStartSyncing(

DVLOG(2) << "[AUTOFILL MIGRATION]"

<< "Printing profiles from web db";

- for (const auto& p : profiles_) {

+ for (auto* p : profiles_) {

vabr (Chromium) 2016/07/19 07:54:09 optional: "const auto*"

vmpstr 2016/07/19 19:49:31 Done.

DVLOG(2) << "[AUTOFILL MIGRATION] "

<< UTF16ToUTF8(p->GetRawInfo(NAME_FIRST))

<< UTF16ToUTF8(p->GetRawInfo(NAME_LAST))