components: Change auto to not deduce raw pointers.

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <list>
 #include <map>
@@ skipping 573 matching lines @@
 
 void PersonalDataManager::UpdateServerCreditCard(
     const CreditCard& credit_card) {
   DCHECK_NE(CreditCard::LOCAL_CARD, credit_card.record_type());
 
   if (is_off_the_record_ || !database_.get())
     return;
 
   // Look up by server id, not GUID.
   CreditCard* existing_credit_card = nullptr;
-  for (auto it : server_credit_cards_) {
+  for (auto* it : server_credit_cards_) {

[vabr (Chromium), 2016/07/19 07:54:09]

optional nit: Could we rename |it| to |server_card| or something similar not
containing hints at iterators?

Also below on line 623.

[vabr (Chromium), 2016/07/19 07:54:09]

optional: Could we make this "const auto*" and change the type of
|existing_credit_card| to "const CreditCard*" to point out that the pointee is
not changed?

[vmpstr, 2016/07/19 19:49:31]

Done.

     if (credit_card.server_id() == it->server_id()) {
       existing_credit_card = it;
       break;
     }
   }
   if (!existing_credit_card)
     return;
 
   DCHECK_NE(existing_credit_card->record_type(), credit_card.record_type());
   DCHECK_EQ(existing_credit_card->Label(), credit_card.Label());
   if (existing_credit_card->record_type() == CreditCard::MASKED_SERVER_CARD) {
     database_->UnmaskServerCreditCard(credit_card,
                                       credit_card.number());
   } else {
     database_->MaskServerCreditCard(credit_card.server_id());
   }
 
   Refresh();
 }
 
 void PersonalDataManager::UpdateServerCardBillingAddress(
     const CreditCard& credit_card) {
   DCHECK_NE(CreditCard::LOCAL_CARD, credit_card.record_type());
 
   if (!database_.get())
     return;
 
   CreditCard* existing_credit_card = nullptr;
-  for (auto it : server_credit_cards_) {
+  for (auto* it : server_credit_cards_) {
     if (credit_card.guid() == it->guid()) {
       existing_credit_card = it;
       break;
     }
   }
   if (!existing_credit_card
       || existing_credit_card->billing_address_id() ==
           credit_card.billing_address_id()) {
     return;
   }
@@ skipping 1111 matching lines @@
         if (profile_to_merge->IsVerified())
           break;
       }
     }
   }
   AutofillMetrics::LogNumberOfProfilesRemovedDuringDedupe(
       profiles_to_delete->size());
 }
 
 }  // namespace autofill