extensions/browser/guest_view/web_view/web_view_permission_helper.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_permission_helper.h ('k') | extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

index 57ff170aa1cf7f286a9b37556471cf046f4ad7a7..dfdb5b7bd2ffc8a24935d66d49b50f7a42c6d3b7 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

@@ -271,9 +271,10 @@ void WebViewPermissionHelper::RequestPointerLockPermission(

void WebViewPermissionHelper::RequestGeolocationPermission(

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

const base::Callback<void(bool)>& callback) {

web_view_permission_helper_delegate_->RequestGeolocationPermission(

- bridge_id, requesting_frame, callback);

+ bridge_id, requesting_frame, user_gesture, callback);

}

void WebViewPermissionHelper::CancelGeolocationPermissionRequest(