Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 211033002: Add runtime feature and property names for unprefixed CSS Transforms (Closed)

Created:
6 years, 9 months ago by dstockwell
Modified:
6 years, 9 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, eseidel, esprehn, ojan, Julien - ping for review
Visibility:
Public.

Description

Add runtime feature and property names for unprefixed CSS Transforms Adds a runtime flag (enabled only for testing) and defines property names for each property defined in CSS Transforms[1]. Future patches will make these properties functional. [1] http://www.w3.org/TR/css3-transforms/ BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170295

Patch Set 1 #

Patch Set 2 : Rebaseline webexposed and fix SVG failures. #

Patch Set 3 : Avoid crashing when properties are specified. #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Remove invalid assert. #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 50 (0 generated)
dstockwell
6 years, 9 months ago (2014-03-25 12:23:29 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-25 12:39:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/20001
6 years, 9 months ago (2014-03-25 12:39:46 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 13:02:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 13:02:14 UTC) #5
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-25 13:32:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/20001
6 years, 9 months ago (2014-03-25 13:32:37 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 13:53:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 13:53:07 UTC) #9
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-25 15:21:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/90001
6 years, 9 months ago (2014-03-25 15:21:47 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 15:53:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 15:53:27 UTC) #13
abarth-chromium
On 2014/03/25 15:53:27, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-25 16:00:35 UTC) #14
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-25 22:40:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/230001
6 years, 9 months ago (2014-03-25 22:40:40 UTC) #16
dstockwell
On 2014/03/25 16:00:35, abarth wrote: > On 2014/03/25 15:53:27, I haz the power (commit-bot) wrote: ...
6 years, 9 months ago (2014-03-25 22:40:45 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 22:48:31 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-25 22:48:31 UTC) #19
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-25 23:07:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/230001
6 years, 9 months ago (2014-03-25 23:07:53 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 23:37:20 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-25 23:37:20 UTC) #23
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 02:22:28 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/370001
6 years, 9 months ago (2014-03-26 02:22:35 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 02:38:17 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 02:38:17 UTC) #27
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-26 02:41:43 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/370001
6 years, 9 months ago (2014-03-26 02:41:46 UTC) #29
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 02:43:10 UTC) #30
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 02:43:24 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/370001
6 years, 9 months ago (2014-03-26 02:43:27 UTC) #32
commit-bot: I haz the power
Change committed as 170005
6 years, 9 months ago (2014-03-26 02:44:23 UTC) #33
vsevik
A revert of this CL has been created in https://codereview.chromium.org/212563007/ by vsevik@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 13:11:16 UTC) #34
vsevik
On 2014/03/26 13:11:16, vsevik wrote: > A revert of this CL has been created in ...
6 years, 9 months ago (2014-03-26 13:46:46 UTC) #35
no longer working on chromium
https://codereview.chromium.org/211033002/diff/370001/Source/core/svg/SVGElement.cpp File Source/core/svg/SVGElement.cpp (right): https://codereview.chromium.org/211033002/diff/370001/Source/core/svg/SVGElement.cpp#newcode66 Source/core/svg/SVGElement.cpp:66: ASSERT(RuntimeEnabledFeatures::cssTransformsUnprefixedEnabled()); This line of code consistently crashes the tab ...
6 years, 9 months ago (2014-03-26 17:19:23 UTC) #36
no longer working on chromium
Can we revert this CL?
6 years, 9 months ago (2014-03-26 17:34:48 UTC) #37
enne (OOO)
A revert of this CL has been created in https://codereview.chromium.org/213193005/ by enne@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 17:39:22 UTC) #38
no longer working on chromium
On 2014/03/26 17:39:22, enne wrote: > A revert of this CL has been created in ...
6 years, 9 months ago (2014-03-26 17:43:44 UTC) #39
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 07:46:57 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/620001
6 years, 9 months ago (2014-03-27 07:47:01 UTC) #41
commit-bot: I haz the power
Change committed as 170149
6 years, 9 months ago (2014-03-27 08:57:14 UTC) #42
alancutter (OOO until 2018)
A revert of this CL has been created in https://codereview.chromium.org/215773003/ by alancutter@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-28 00:10:20 UTC) #43
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 07:13:55 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/640001
6 years, 9 months ago (2014-03-28 07:13:57 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 07:16:28 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-28 07:16:29 UTC) #47
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 07:24:02 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211033002/640001
6 years, 9 months ago (2014-03-28 07:24:05 UTC) #49
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 08:21:04 UTC) #50
Message was sent while issue was closed.
Change committed as 170295

Powered by Google App Engine
This is Rietveld 408576698