Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 213193005: Revert of Add runtime feature and property names for unprefixed CSS Transforms (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, eseidel, esprehn, ojan, Julien - ping for review
Visibility:
Public.

Description

Revert of Add runtime feature and property names for unprefixed CSS Transforms (https://codereview.chromium.org/211033002/) Reason for revert: Likely the cause of asserts in ChromiumOS interactive_ui tests: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/34285 e.g. @@@STEP_LOG_LINE@TestShowTwice@../../third_party/WebKit/Source/core/svg/SVGElement.cpp(66) : void WebCore::mapAttributeToCSSProperty(WTF::HashMap\u003CWTF::StringImpl*, WebCore::CSSPropertyID>*, const WebCore::QualifiedName&)@@@ Original issue's description: > Add runtime feature and property names for unprefixed CSS Transforms > > Adds a runtime flag (enabled only for testing) and defines property names > for each property defined in CSS Transforms[1]. Future patches will make > these properties functional. > > [1] http://www.w3.org/TR/css3-transforms/ > > NOTRY=true > BUG=154772 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170005 TBR=eseidel@chromium.org,esprehn@chromium.org,xians@chromium.org,dstockwell@chromium.org NOTREECHECKS=true NOTRY=true BUG=154772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -66 lines) Patch
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
Created Revert of Add runtime feature and property names for unprefixed CSS Transforms
6 years, 9 months ago (2014-03-26 17:39:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/213193005/1
6 years, 9 months ago (2014-03-26 17:39:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 17:39:36 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/webexposed/css-properties-as-js-properties-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 17:39:37 UTC) #4
enne (OOO)
6 years, 9 months ago (2014-03-26 17:42:56 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698