Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 212563007: Revert of Add runtime feature and property names for unprefixed CSS Transforms (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
dstockwell, esprehn, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, eseidel, esprehn, ojan, Julien - ping for review
Visibility:
Public.

Description

Revert of Add runtime feature and property names for unprefixed CSS Transforms (https://codereview.chromium.org/211033002/) Reason for revert: Breaks telemetry_unittests: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13762 Here is how you can run the tests after you build debug chrome: tools/telemetry/run_tests --browser=debug web_components.web_components_unittest Original issue's description: > Add runtime feature and property names for unprefixed CSS Transforms > > Adds a runtime flag (enabled only for testing) and defines property names > for each property defined in CSS Transforms[1]. Future patches will make > these properties functional. > > [1] http://www.w3.org/TR/css3-transforms/ > > NOTRY=true > BUG=154772 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170005 TBR=eseidel@chromium.org,esprehn@chromium.org,dstockwell@chromium.org NOTREECHECKS=true NOTRY=true BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170053

Patch Set 1 #

Patch Set 2 : Revert three patches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -141 lines) Patch
D LayoutTests/transforms/backface-visibility-parsing.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/transforms/resources/parsing-test-helper.js View 1 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/transforms/transform-style-parsing.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 5 chunks +0 lines, -11 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 4 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 3 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 3 chunks +0 lines, -8 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
Created Revert of Add runtime feature and property names for unprefixed CSS Transforms
6 years, 9 months ago (2014-03-26 13:11:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212563007/1
6 years, 9 months ago (2014-03-26 13:11:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 13:11:26 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/css/CSSComputedStyleDeclaration.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 13:11:26 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-26 13:16:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212563007/160001
6 years, 9 months ago (2014-03-26 13:16:49 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 13:17:23 UTC) #7
Message was sent while issue was closed.
Change committed as 170053

Powered by Google App Engine
This is Rietveld 408576698