Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2110323003: Support serialization of loadLibrary (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support serialization of loadLibrary Adds support for serialization of the 'loadLibrary' getter implicitly defined on deferred prefixes. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/ee29d16836fbefae7fe680ec5eb4afd963ee3f49

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -17 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +2 lines, -1 line 1 comment Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 5 chunks +15 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 7 chunks +30 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 4 chunks +12 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +3 lines, -2 lines 2 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +2 lines, -1 line 1 comment Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 4 chunks +21 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2110323003/diff/20001/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/2110323003/diff/20001/pkg/compiler/lib/src/dart2js.dart#newcode475 pkg/compiler/lib/src/dart2js.dart:475: resolutionInputs.contains(resolutionOutput)) { Same problem fixed more thoroughly in https://codereview.chromium.org/2104233003/ ...
4 years, 5 months ago (2016-06-30 11:09:33 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-06-30 17:04:43 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-01 08:48:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ee29d16836fbefae7fe680ec5eb4afd963ee3f49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698