Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2560)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/compiler/dart2js/js_spec_string_test.dart

Issue 2110323003: Support serialization of loadLibrary (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: dartfmt Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/dart2js.dart ('K') | « pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart ('k') | tests/compiler/dart2js/parser_helper.dart » ('j') | tests/compiler/dart2js/parser_helper.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/js_spec_string_test.dart
diff --git a/tests/compiler/dart2js/js_spec_string_test.dart b/tests/compiler/dart2js/js_spec_string_test.dart
index 01c9f64a4a4db851364cd41effae42e3321725f3..fdd59da13b990a993eecd4882c5256fed77888bb 100644
--- a/tests/compiler/dart2js/js_spec_string_test.dart
+++ b/tests/compiler/dart2js/js_spec_string_test.dart
@@ -20,15 +20,16 @@ class Listener extends DiagnosticReporter {
errorMessage = message;
throw "error";
}
- reportError(message, [infos]) {
+ reportError(message, [infos = const <DiagnosticMessage>[]]) {
Johnni Winther 2016/06/30 11:09:33 Analyzer warnings that popped up during developmen
errorMessage =
'${message.message.arguments}'; // E.g. "{text: Duplicate tag 'new'.}"
throw "error";
}
@override
- DiagnosticMessage createMessage(spannable, messageKind, [arguments]) {
+ DiagnosticMessage createMessage(spannable, messageKind,
+ [arguments = const {}]) {
Johnni Winther 2016/06/30 11:09:33 Ditto
return new DiagnosticMessage(null, spannable,
MessageTemplate.TEMPLATES[messageKind].message(arguments));
}
« pkg/compiler/lib/src/dart2js.dart ('K') | « pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart ('k') | tests/compiler/dart2js/parser_helper.dart » ('j') | tests/compiler/dart2js/parser_helper.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698