pkg/compiler/lib/src/dart2js.dart - Issue 2110323003: Support serialization of loadLibrary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 2110323003: Support serialization of loadLibrary (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: dartfmt Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/dart2js.dart

diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart

index b82ad535387d5ae5c7e9a48398246c9700e7f365..99a577481ec8db86be9d4ffe5861b4ba7cfba08a 100644

--- a/pkg/compiler/lib/src/dart2js.dart

+++ b/pkg/compiler/lib/src/dart2js.dart

@@ -471,7 +471,8 @@ Future<api.CompilationResult> compile(List<String> argv) {

api.Diagnostic.INFO);

}

if (resolveOnly) {

- if (resolutionInputs.contains(resolutionOutput)) {

+ if (resolutionInputs != null &&

+ resolutionInputs.contains(resolutionOutput)) {

Johnni Winther 2016/06/30 11:09:33 Same problem fixed more thoroughly in https://code

helpAndFail("Resolution input '${resolutionOutput}' can't be used as "

"resolution output. Use the '--out' option to specify another "

"resolution output.");