Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2110323002:
Change the Frame Calculation to Use GetSystemMetricsForHwnd (Closed)
DescriptionChange the Frame Calculation to Use GetSystemMetricsForHwnd
SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI.
GetSystemMetricsForHwnd accounts for the system metrics taking into account the
DPI of the HWND.
BUG=426656
Committed: https://crrev.com/39ec034d1110e65d77481e1362c8f4ba6429f7fb
Cr-Commit-Position: refs/heads/master@{#403326}
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 24 (13 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robliao@chromium.org changed reviewers: + pkasting@chromium.org
pkasting: Please review this change. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
robliao@chromium.org changed reviewers: + sky@chromium.org - pkasting@chromium.org
pkasting to CC for now (since marked slow). sky: Please review this one statement change. Thanks!
Description was changed from ========== Change the Frame Calculation to Use GetSystemMetricsForHwnd SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI. GetSystemMetricsForHwnd accounts for the system metrics taking into account the DPI of the HWND. BUG=426656 ========== to ========== Change the Frame Calculation to Use GetSystemMetricsForHwnd SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI. GetSystemMetricsForHwnd accounts for the system metrics taking into account the DPI of the HWND. BUG=426656 ==========
LGTM
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change the Frame Calculation to Use GetSystemMetricsForHwnd SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI. GetSystemMetricsForHwnd accounts for the system metrics taking into account the DPI of the HWND. BUG=426656 ========== to ========== Change the Frame Calculation to Use GetSystemMetricsForHwnd SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI. GetSystemMetricsForHwnd accounts for the system metrics taking into account the DPI of the HWND. BUG=426656 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Change the Frame Calculation to Use GetSystemMetricsForHwnd SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI. GetSystemMetricsForHwnd accounts for the system metrics taking into account the DPI of the HWND. BUG=426656 ========== to ========== Change the Frame Calculation to Use GetSystemMetricsForHwnd SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI. GetSystemMetricsForHwnd accounts for the system metrics taking into account the DPI of the HWND. BUG=426656 Committed: https://crrev.com/39ec034d1110e65d77481e1362c8f4ba6429f7fb Cr-Commit-Position: refs/heads/master@{#403326} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/39ec034d1110e65d77481e1362c8f4ba6429f7fb Cr-Commit-Position: refs/heads/master@{#403326} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
