Add ScreenWin::GetSystemMetricsForHwnd

Add ScreenWin::GetSystemMetricsForHwnd

Callers of GetSystemMetrics occassionally need to get system metrics in the
using the HWND's DPI. An example is calculating the client frame using
SM_CXSIZEFRAME. This will be different depending on the DPI of the display.

BUG=426656
Committed: https://crrev.com/af3fa67c6e926403d00a4ef077e4ef180f625287
Cr-Commit-Position: refs/heads/master@{#403271}

[robliao, 2016-06-30 00:53:11]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 00:53:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2016-06-30 01:24:50]

robliao@chromium.org changed reviewers:
+ oshima@chromium.org

[robliao, 2016-06-30 01:24:51]

oshima: Please review this changelist. Thanks!

[commit-bot: I haz the power, 2016-06-30 01:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 01:55:35]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-06-30 19:06:13]

lgtm

https://codereview.chromium.org/2110313002/diff/20001/ui/display/win/screen_w...
File ui/display/win/screen_win.cc (right):

https://codereview.chromium.org/2110313002/diff/20001/ui/display/win/screen_w...
ui/display/win/screen_win.cc:302: if (!g_screen_win_instance)
is this for unit test case?

https://codereview.chromium.org/2110313002/diff/20001/ui/display/win/screen_w...
ui/display/win/screen_win.cc:309: ? GetScaleFactorForHWND(hwnd) /
primary_display.device_scale_factor()
calling this "scale factor" is confusing. Can you call it like
the "scale_to_primary_metrics" or something like that?

[robliao, 2016-06-30 19:20:24]

Thanks for the quick review!

https://codereview.chromium.org/2110313002/diff/20001/ui/display/win/screen_w...
File ui/display/win/screen_win.cc (right):

https://codereview.chromium.org/2110313002/diff/20001/ui/display/win/screen_w...
ui/display/win/screen_win.cc:302: if (!g_screen_win_instance)
On 2016/06/30 19:06:12, oshima wrote:
> is this for unit test case?

Yup. This is for the unit tests.

https://codereview.chromium.org/2110313002/diff/20001/ui/display/win/screen_w...
ui/display/win/screen_win.cc:309: ? GetScaleFactorForHWND(hwnd) /
primary_display.device_scale_factor()
On 2016/06/30 19:06:12, oshima wrote:
> calling this "scale factor" is confusing. Can you call it like
> the "scale_to_primary_metrics" or something like that?

I went with metrics_relative_scale_factor. How's that?

[robliao, 2016-06-30 19:20:29]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 19:21:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:10:23]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-06-30 20:28:54]

The CQ bit was checked by robliao@chromium.org

[robliao, 2016-06-30 20:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2110313002/#ps40001
(title: "CR Feedback")

[commit-bot: I haz the power, 2016-06-30 20:29:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:35:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 20:35:59]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 20:39:08]

Description was changed from

==========
Add ScreenWin::GetSystemMetricsForHwnd

Callers of GetSystemMetrics occassionally need to get system metrics in the
using the HWND's DPI. An example is calculating the client frame using
SM_CXSIZEFRAME. This will be different depending on the DPI of the display.

BUG=426656
==========

to

==========
Add ScreenWin::GetSystemMetricsForHwnd

Callers of GetSystemMetrics occassionally need to get system metrics in the
using the HWND's DPI. An example is calculating the client frame using
SM_CXSIZEFRAME. This will be different depending on the DPI of the display.

BUG=426656

Committed: https://crrev.com/af3fa67c6e926403d00a4ef077e4ef180f625287
Cr-Commit-Position: refs/heads/master@{#403271}
==========

[commit-bot: I haz the power, 2016-06-30 20:39:09]

Patchset 3 (id:??) landed as
https://crrev.com/af3fa67c6e926403d00a4ef077e4ef180f625287
Cr-Commit-Position: refs/heads/master@{#403271}