Add Per-Monitor DPI Switches for Windows 10

Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656, 624672, 625289
Committed: https://crrev.com/8e6e31b4b73153f190507e49ab9caa4634ff497f
Cr-Commit-Position: refs/heads/master@{#403551}

[robliao, 2016-07-01 21:08:18]

robliao@chromium.org changed reviewers:
+ thestig@chromium.org

[robliao, 2016-07-01 21:08:18]

Alright. I'm going with a flag in case I need other teams to repro with this
feature enabled.

The bug that caused the original CL to back out is turning out to be quite
involved.

[robliao, 2016-07-01 21:09:01]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 21:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2016-07-01 21:12:14]

Description was changed from

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

BUG=426656,624672
==========

to

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672
==========

[robliao, 2016-07-01 21:13:51]

Description was changed from

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672
==========

to

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672,625289
==========

[Lei Zhang, 2016-07-01 21:15:36]

https://codereview.chromium.org/2118953002/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/2118953002/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.h:375: extern const char kDisablePerMonitorDpi[];
Alphabetical order please, as requested on line 26.

[Lei Zhang, 2016-07-01 21:16:57]

lgtm

[robliao, 2016-07-01 21:23:36]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2016-07-01 21:27:07]

https://codereview.chromium.org/2118953002/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/2118953002/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.h:375: extern const char kDisablePerMonitorDpi[];
On 2016/07/01 21:15:36, Lei Zhang wrote:
> Alphabetical order please, as requested on line 26.

Ah. I thought that only applied the top-most section. I'll clean up the rest of
the file in another CL. Done for this one.

[robliao, 2016-07-01 21:27:16]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 21:27:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-01 22:04:20]

On 2016/07/01 21:27:07, robliao wrote:
> Ah. I thought that only applied the top-most section. I'll clean up the rest
of
> the file in another CL. Done for this one.

It would be nice if every section was in order. The Windows one was already, so
let's keep it that way.

[commit-bot: I haz the power, 2016-07-01 22:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 22:18:17]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-07-01 22:23:38]

The CQ bit was checked by robliao@chromium.org

[robliao, 2016-07-01 22:23:39]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2118953002/#ps20001
(title: "CR Feedback")

[commit-bot: I haz the power, 2016-07-01 22:23:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 22:28:58]

Description was changed from

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672,625289
==========

to

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672,625289
==========

[commit-bot: I haz the power, 2016-07-01 22:28:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 22:32:22]

Description was changed from

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672,625289
==========

to

==========
Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG=426656,624672,625289

Committed: https://crrev.com/8e6e31b4b73153f190507e49ab9caa4634ff497f
Cr-Commit-Position: refs/heads/master@{#403551}
==========

[commit-bot: I haz the power, 2016-07-01 22:32:23]

Patchset 2 (id:??) landed as
https://crrev.com/8e6e31b4b73153f190507e49ab9caa4634ff497f
Cr-Commit-Position: refs/heads/master@{#403551}