Issue 211003002: DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target.

Issue 211003002: DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target. (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target. R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169938

Patch Set 1 #

Total comments: 1

Patch Set 2 : For landing #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -170 lines)			Patch
M	LayoutTests/http/tests/inspector/debugger-test.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/jump-to-previous-editing-location.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/EditingLocationHistoryManager.js	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/ExtensionServer.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/FilteredItemSelectionDialog.js	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/devtools/front_end/InplaceFormatterEditorAction.js	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/ScriptFormatterEditorAction.js	View		4 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/SourcesEditor.js	View		12 chunks	+25 lines, -94 lines	0 comments	Download
M	Source/devtools/front_end/SourcesPanel.js	View	1	18 chunks	+87 lines, -26 lines	0 comments	Download
M	Source/devtools/front_end/Tests.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/modules.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sourcesPanel.css	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sourcesView.css	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/211003002/diff/1/Source/devtools/front_end/SourcesPanel.js File Source/devtools/front_end/SourcesPanel.js (right): https://chromiumcodereview.appspot.com/211003002/diff/1/Source/devtools/front_end/SourcesPanel.js#newcode1100 Source/devtools/front_end/SourcesPanel.js:1100: this._dragMaskElement = this._element.createChild("div", "fill drag-mask"); drag-mask is defined ...

6 years, 9 months ago (2014-03-25 11:58:15 UTC) #2

pfeldman

6 years, 9 months ago (2014-03-25 12:54:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r169938 (presubmit successful).

Expand Messages | Collapse Messages