Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/devtools/front_end/EditingLocationHistoryManager.js

Issue 211003002: DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: For landing Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/EditingLocationHistoryManager.js
diff --git a/Source/devtools/front_end/EditingLocationHistoryManager.js b/Source/devtools/front_end/EditingLocationHistoryManager.js
index 4c7bba5bd9871287d9a25fd44a9dd4d5e383b947..9883664e0602294a70c6bc1420612d4b8146eeda 100644
--- a/Source/devtools/front_end/EditingLocationHistoryManager.js
+++ b/Source/devtools/front_end/EditingLocationHistoryManager.js
@@ -30,12 +30,12 @@
/**
* @constructor
- * @param {!WebInspector.SourcesEditor} sourcesEditor
+ * @param {!WebInspector.SourcesView} sourcesView
* @param {!function():?WebInspector.SourceFrame} currentSourceFrameCallback
*/
-WebInspector.EditingLocationHistoryManager = function(sourcesEditor, currentSourceFrameCallback)
+WebInspector.EditingLocationHistoryManager = function(sourcesView, currentSourceFrameCallback)
{
- this._sourcesEditor = sourcesEditor;
+ this._sourcesView = sourcesView;
this._historyManager = new WebInspector.SimpleHistoryManager(WebInspector.EditingLocationHistoryManager.HistoryDepth);
this._currentSourceFrameCallback = currentSourceFrameCallback;
}
@@ -99,7 +99,7 @@ WebInspector.EditingLocationHistoryManager.prototype = {
var sourceFrame = this._currentSourceFrameCallback();
if (!sourceFrame)
return;
- var entry = new WebInspector.EditingLocationHistoryEntry(this._sourcesEditor, this, sourceFrame, selection);
+ var entry = new WebInspector.EditingLocationHistoryEntry(this._sourcesView, this, sourceFrame, selection);
active.merge(entry);
},
@@ -111,7 +111,7 @@ WebInspector.EditingLocationHistoryManager.prototype = {
var sourceFrame = this._currentSourceFrameCallback();
if (!sourceFrame)
return;
- var entry = new WebInspector.EditingLocationHistoryEntry(this._sourcesEditor, this, sourceFrame, selection);
+ var entry = new WebInspector.EditingLocationHistoryEntry(this._sourcesView, this, sourceFrame, selection);
this._historyManager.push(entry);
},
@@ -133,14 +133,14 @@ WebInspector.EditingLocationHistoryManager.prototype = {
/**
* @constructor
* @implements {WebInspector.HistoryEntry}
- * @param {!WebInspector.SourcesEditor} sourcesEditor
+ * @param {!WebInspector.SourcesView} sourcesView
* @param {!WebInspector.EditingLocationHistoryManager} editingLocationManager
* @param {!WebInspector.SourceFrame} sourceFrame
* @param {!WebInspector.TextRange} selection
*/
-WebInspector.EditingLocationHistoryEntry = function(sourcesEditor, editingLocationManager, sourceFrame, selection)
+WebInspector.EditingLocationHistoryEntry = function(sourcesView, editingLocationManager, sourceFrame, selection)
{
- this._sourcesEditor = sourcesEditor;
+ this._sourcesView = sourcesView;
this._editingLocationManager = editingLocationManager;
var uiSourceCode = sourceFrame.uiSourceCode();
this._projectId = uiSourceCode.project().id();
@@ -191,6 +191,6 @@ WebInspector.EditingLocationHistoryEntry.prototype = {
return;
this._editingLocationManager.updateCurrentState();
- this._sourcesEditor.showSourceLocation(uiSourceCode, position.lineNumber, position.columnNumber);
+ this._sourcesView.showSourceLocation(uiSourceCode, position.lineNumber, position.columnNumber);
}
};
« no previous file with comments | « LayoutTests/inspector/jump-to-previous-editing-location.html ('k') | Source/devtools/front_end/ExtensionServer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698