Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: Source/devtools/front_end/FilteredItemSelectionDialog.js

Issue 211003002: DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: For landing Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/FilteredItemSelectionDialog.js
diff --git a/Source/devtools/front_end/FilteredItemSelectionDialog.js b/Source/devtools/front_end/FilteredItemSelectionDialog.js
index 269f4ec44c7b0a2943549d66e4ceccc1a068e7c7..e530eeb0d3a124d116fa52806f6dda9d3f1a8ae1 100644
--- a/Source/devtools/front_end/FilteredItemSelectionDialog.js
+++ b/Source/devtools/front_end/FilteredItemSelectionDialog.js
@@ -766,13 +766,13 @@ WebInspector.SelectUISourceCodeDialog.prototype = {
/**
* @constructor
* @extends {WebInspector.SelectUISourceCodeDialog}
- * @param {!WebInspector.SourcesEditor} sourcesEditor
+ * @param {!WebInspector.SourcesView} sourcesView
* @param {!Map.<!WebInspector.UISourceCode, number>=} defaultScores
*/
-WebInspector.OpenResourceDialog = function(sourcesEditor, defaultScores)
+WebInspector.OpenResourceDialog = function(sourcesView, defaultScores)
{
WebInspector.SelectUISourceCodeDialog.call(this, defaultScores);
- this._sourcesEditor = sourcesEditor;
+ this._sourcesView = sourcesView;
}
WebInspector.OpenResourceDialog.prototype = {
@@ -785,10 +785,10 @@ WebInspector.OpenResourceDialog.prototype = {
uiSourceCodeSelected: function(uiSourceCode, lineNumber, columnNumber)
{
if (!uiSourceCode)
- uiSourceCode = this._sourcesEditor.currentUISourceCode();
+ uiSourceCode = this._sourcesView.currentUISourceCode();
if (!uiSourceCode)
return;
- this._sourcesEditor.showSourceLocation(uiSourceCode, lineNumber, columnNumber);
+ this._sourcesView.showSourceLocation(uiSourceCode, lineNumber, columnNumber);
},
/**
@@ -813,17 +813,17 @@ WebInspector.OpenResourceDialog.prototype = {
}
/**
- * @param {!WebInspector.SourcesEditor} sourcesEditor
+ * @param {!WebInspector.SourcesView} sourcesView
* @param {!Element} relativeToElement
* @param {string=} query
* @param {!Map.<!WebInspector.UISourceCode, number>=} defaultScores
*/
-WebInspector.OpenResourceDialog.show = function(sourcesEditor, relativeToElement, query, defaultScores)
+WebInspector.OpenResourceDialog.show = function(sourcesView, relativeToElement, query, defaultScores)
{
if (WebInspector.Dialog.currentInstance())
return;
- var filteredItemSelectionDialog = new WebInspector.FilteredItemSelectionDialog(new WebInspector.OpenResourceDialog(sourcesEditor, defaultScores));
+ var filteredItemSelectionDialog = new WebInspector.FilteredItemSelectionDialog(new WebInspector.OpenResourceDialog(sourcesView, defaultScores));
filteredItemSelectionDialog.renderAsTwoRows();
if (query)
filteredItemSelectionDialog.setQuery(query);
« no previous file with comments | « Source/devtools/front_end/ExtensionServer.js ('k') | Source/devtools/front_end/InplaceFormatterEditorAction.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698