Remove redundant calls to HTMLSelectElement::setRecalcListItems().

Remove redundant calls to HTMLSelectElement::setRecalcListItems().

When we remove or insert an OPTION from/to a SELECT element,
setRecalcListItems() was called twice.
 - HTMLSelectElement::childrenChanged()
 - HTMLSelectElement::optionInserted() or optionRemoved().

Also, it was called even when a text node is added to a SELECT element. This CL
fixes them.

We stops to override childrenChange(). HTMLOptGroupElement and HTMLHRElement
override insertedInto() and removedFrom(), and they notify these events to the
owner SELECT element like HTMLOptionElement does.

This is a preparation to optimize setRecalcListItems().

BUG=624220
Committed: https://crrev.com/5850ba2952d13224b95b9cd78248d4216eb76d96
Cr-Commit-Position: refs/heads/master@{#402781}

[tkent, 2016-06-29 07:44:03]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-06-29 07:44:03]

Keishi, would you review this please?

[keishi, 2016-06-29 08:46:40]

LGTM

https://codereview.chromium.org/2109993003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLHRElement.cpp (right):

https://codereview.chromium.org/2109993003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLHRElement.cpp:111: if (insertionPoint ==
select || (isHTMLOptGroupElement(*insertionPoint) &&
insertionPoint->parentNode() == select))
Isn't existence of ownerSelectElement enough? do we need to check
insertionPoint?

[tkent, 2016-06-29 08:58:05]

Thank you for reviewing this.

https://codereview.chromium.org/2109993003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLHRElement.cpp (right):

https://codereview.chromium.org/2109993003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLHRElement.cpp:111: if (insertionPoint ==
select || (isHTMLOptGroupElement(*insertionPoint) &&
insertionPoint->parentNode() == select))
On 2016/06/29 at 08:46:40, keishi wrote:
> Isn't existence of ownerSelectElement enough? do we need to check
insertionPoint?

Checking only existence of ownerSelectElement isn't efficient.  It would call
hrInsertedOrRemoved() even if a subtree including <select><hr/>...</select> is
appended to another element.

[tkent, 2016-06-29 11:42:52]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-06-29 11:43:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 11:46:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 11:48:53]

Description was changed from

==========
Remove redundant calls to HTMLSelectElement::setRecalcListItems().

When we remove or insert an OPTION from/to a SELECT element,
setRecalcListItems() was called twice.
 - HTMLSelectElement::childrenChanged()
 - HTMLSelectElement::optionInserted() or optionRemoved().

Also, it was called even when a text node is added to a SELECT element. This CL
fixes them.

We stops to override childrenChange(). HTMLOptGroupElement and HTMLHRElement
override insertedInto() and removedFrom(), and they notify these events to the
owner SELECT element like HTMLOptionElement does.

This is a preparation to optimize setRecalcListItems().

BUG=624220
==========

to

==========
Remove redundant calls to HTMLSelectElement::setRecalcListItems().

When we remove or insert an OPTION from/to a SELECT element,
setRecalcListItems() was called twice.
 - HTMLSelectElement::childrenChanged()
 - HTMLSelectElement::optionInserted() or optionRemoved().

Also, it was called even when a text node is added to a SELECT element. This CL
fixes them.

We stops to override childrenChange(). HTMLOptGroupElement and HTMLHRElement
override insertedInto() and removedFrom(), and they notify these events to the
owner SELECT element like HTMLOptionElement does.

This is a preparation to optimize setRecalcListItems().

BUG=624220

Committed: https://crrev.com/5850ba2952d13224b95b9cd78248d4216eb76d96
Cr-Commit-Position: refs/heads/master@{#402781}
==========

[commit-bot: I haz the power, 2016-06-29 11:48:54]

Patchset 1 (id:??) landed as
https://crrev.com/5850ba2952d13224b95b9cd78248d4216eb76d96
Cr-Commit-Position: refs/heads/master@{#402781}