Remove redundant calls to HTMLSelectElement::setRecalcListItems().

third_party/WebKit/Source/core/html/HTMLHRElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "core/html/HTMLHRElement.h"
 
 #include "core/CSSPropertyNames.h"
 #include "core/CSSValueKeywords.h"
 #include "core/HTMLNames.h"
 #include "core/css/CSSColorValue.h"
 #include "core/css/StylePropertySet.h"
+#include "core/html/HTMLOptGroupElement.h"
+#include "core/html/HTMLSelectElement.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 inline HTMLHRElement::HTMLHRElement(Document& document)
     : HTMLElement(hrTag, document)
 {
 }
 
@@ skipping 43 matching lines @@
         int size = si->toInt();
         if (size <= 1)
             addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderBottomWidth, 0, CSSPrimitiveValue::UnitType::Pixels);
         else
             addPropertyToPresentationAttributeStyle(style, CSSPropertyHeight, size - 2, CSSPrimitiveValue::UnitType::Pixels);
     } else {
         HTMLElement::collectStyleForPresentationAttribute(name, value, style);
     }
 }
 
+HTMLSelectElement* HTMLHRElement::ownerSelectElement() const
+{
+    if (!parentNode())
+        return nullptr;
+    if (isHTMLSelectElement(*parentNode()))
+        return toHTMLSelectElement(parentNode());
+    if (!isHTMLOptGroupElement(*parentNode()))
+        return nullptr;
+    Node* grandParent = parentNode()->parentNode();
+    return isHTMLSelectElement(grandParent) ? toHTMLSelectElement(grandParent) : nullptr;
+}
+
+Node::InsertionNotificationRequest HTMLHRElement::insertedInto(ContainerNode* insertionPoint)
+{
+    HTMLElement::insertedInto(insertionPoint);
+    if (HTMLSelectElement* select = ownerSelectElement()) {
+        if (insertionPoint == select || (isHTMLOptGroupElement(*insertionPoint) && insertionPoint->parentNode() == select))

[keishi, 2016/06/29 08:46:40]

Isn't existence of ownerSelectElement enough? do we need to check
insertionPoint?

[tkent, 2016/06/29 08:58:04]

Checking only existence of ownerSelectElement isn't efficient.  It would call
hrInsertedOrRemoved() even if a subtree including <select><hr/>...</select> is
appended to another element.

+            select->hrInsertedOrRemoved(*this);
+    }
+    return InsertionDone;
+}
+
+void HTMLHRElement::removedFrom(ContainerNode* insertionPoint)
+{
+    if (isHTMLSelectElement(*insertionPoint)) {
+        if (!parentNode() || isHTMLOptGroupElement(*parentNode()))
+            toHTMLSelectElement(insertionPoint)->hrInsertedOrRemoved(*this);
+    } else if (isHTMLOptGroupElement(*insertionPoint)) {
+        Node* parent = insertionPoint->parentNode();
+        if (isHTMLSelectElement(parent))
+            toHTMLSelectElement(parent)->hrInsertedOrRemoved(*this);
+    }
+    HTMLElement::removedFrom(insertionPoint);
+}
+
 } // namespace blink