Remove redundant calls to HTMLSelectElement::setRecalcListItems().

third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
@@ skipping 402 matching lines @@
 HTMLCollection* HTMLSelectElement::selectedOptions()
 {
     return ensureCachedCollection<HTMLCollection>(SelectedOptions);
 }
 
 HTMLOptionsCollection* HTMLSelectElement::options()
 {
     return ensureCachedCollection<HTMLOptionsCollection>(SelectOptions);
 }
 
-void HTMLSelectElement::childrenChanged(const ChildrenChange& change)
-{
-    setRecalcListItems();
-    setNeedsValidityCheck();
-    m_lastOnChangeSelection.clear();
-
-    HTMLFormControlElementWithState::childrenChanged(change);
-}
-
 void HTMLSelectElement::optionElementChildrenChanged(const HTMLOptionElement& option)
 {
     setNeedsValidityCheck();
 
     if (layoutObject()) {
         if (option.selected() && usesMenuList())
             layoutObject()->updateFromElement();
         if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCache())
             cache->childrenChanged(this);
     }
@@ skipping 536 matching lines @@
 {
     ASSERT(option.ownerSelectElement() == this);
     setRecalcListItems();
     if (optionIsSelected) {
         selectOption(&option);
     } else {
         // No need to reset if we already have a selected option.
         if (!m_lastOnChangeOption)
             resetToDefaultSelection();
     }
+    setNeedsValidityCheck();
+    m_lastOnChangeSelection.clear();
 }
 
 void HTMLSelectElement::optionRemoved(const HTMLOptionElement& option)
 {
     setRecalcListItems();
     if (option.selected())
         resetToDefaultSelection(ResetReasonSelectedOptionRemoved);
     else if (!m_lastOnChangeOption)
         resetToDefaultSelection();
     if (m_lastOnChangeOption == &option)
         m_lastOnChangeOption.clear();
     if (m_optionToScrollTo == &option)
         m_optionToScrollTo.clear();
     if (m_activeSelectionAnchor == &option)
         m_activeSelectionAnchor.clear();
     if (m_activeSelectionEnd == &option)
         m_activeSelectionEnd.clear();
     if (option.selected())
         setAutofilled(false);
+    setNeedsValidityCheck();
+    m_lastOnChangeSelection.clear();
+}
+
+void HTMLSelectElement::optGroupInsertedOrRemoved(const HTMLOptGroupElement&)
+{
+    setRecalcListItems();
+    setNeedsValidityCheck();
+    m_lastOnChangeSelection.clear();
+}
+
+void HTMLSelectElement::hrInsertedOrRemoved(const HTMLHRElement&)
+{
+    setRecalcListItems();
+    m_lastOnChangeSelection.clear();
 }
 
 void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)
 {
     selectOption(optionIndex < 0 ? nullptr : item(optionIndex), flags);
 }
 
 void HTMLSelectElement::selectOption(HTMLOptionElement* option, SelectOptionFlags flags)
 {
     selectOption(option, option ? option->index() : -1, flags);
@@ skipping 1061 matching lines @@
 }
 
 void HTMLSelectElement::didMutateSubtree()
 {
     DCHECK(popupIsVisible());
     DCHECK(m_popup);
     m_popup->updateFromElement(PopupMenu::ByDOMChange);
 }
 
 } // namespace blink