third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

index d8fa7126b96a79200ab6089ea39126e41824eb70..ca13c117286e8547f04f5c32b08ef921c4301aca 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

@@ -39,7 +39,6 @@ WebInspector.DebuggerModel = function(target)

target.registerDebuggerDispatcher(new WebInspector.DebuggerDispatcher(this));

this._agent = target.debuggerAgent();

- WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.TargetDisposed, this._targetDisposed, this);

/** @type {?WebInspector.DebuggerPausedDetails} */

this._debuggerPausedDetails = null;

@@ -786,14 +785,8 @@ WebInspector.DebuggerModel.prototype = {

}

- /**

- * @param {!WebInspector.Event} event

- */

- _targetDisposed: function(event)

+ dispose: function()

{

- var target = /** @type {!WebInspector.Target} */ (event.data);

- if (target !== this.target())

- return;

WebInspector.moduleSetting("pauseOnExceptionEnabled").removeChangeListener(this._pauseOnExceptionStateChanged, this);

WebInspector.moduleSetting("pauseOnCaughtException").removeChangeListener(this._pauseOnExceptionStateChanged, this);

WebInspector.moduleSetting("enableAsyncStackTraces").removeChangeListener(this.asyncStackTracesStateChanged, this);