third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js b/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

index 5219b8998c90b404a472dee6a66a5605ca3ac4a9..5978ef00b666e3cd70f7d498245acf81c9b0ae64 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

@@ -66,7 +66,7 @@ WebInspector.HAREntry.prototype = {

if (this._request.connectionId !== "0")

entry.connection = this._request.connectionId;

- var page = this._request.target().networkLog.pageLoadForRequest(this._request);

+ var page = this._request.networkLog().pageLoadForRequest(this._request);

if (page)

entry.pageref = "page_" + page.id;

return entry;

@@ -328,7 +328,7 @@ WebInspector.HARLog.prototype = {

var pages = [];

for (var i = 0; i < this._requests.length; ++i) {

var request = this._requests[i];

- var page = request.target().networkLog.pageLoadForRequest(request);

+ var page = request.networkLog().pageLoadForRequest(request);

if (!page || seenIdentifiers[page.id])

continue;

seenIdentifiers[page.id] = true;