third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

index 782a8d1b3c12536adefeee3aa0b4bd8a55245b4c..523ecabc9892f6b1b5cf7202654febe467cb5714 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

@@ -269,7 +269,8 @@ WebInspector.ConsoleMessage = function(target, source, level, messageText, type,

this._messageId = messageId || 0;

this._relatedMessageId = relatedMessageId || 0;

- this.request = requestId ? target.networkLog.requestForId(requestId) : null;

+ var networkLog = target && WebInspector.NetworkLog.fromTarget(target);

+ this.request = (requestId && networkLog) ? networkLog.requestForId(requestId) : null;

if (this.request) {

var initiator = this.request.initiator();