Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index f9f215d051075be6160b299321625dfc1a8e54ba..8c8748bfb858a998fbaaa0c822000a21fe0a9695 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -308,7 +308,12 @@ WebInspector.Main.prototype = {
WebInspector.RemoteDebuggingTerminatedScreen.show(event.data.reason);
}
- var targetType = Runtime.queryParam("isSharedWorker") ? WebInspector.Target.Type.ServiceWorker : WebInspector.Target.Type.Page;
+ var targetType = WebInspector.Target.Type.Page;
+ if (Runtime.queryParam("isSharedWorker"))
+ targetType = WebInspector.Target.Type.ServiceWorker;
+ else if (Runtime.queryParam("v8only"))
+ targetType = WebInspector.Target.Type.JSInspector;
+
this._mainTarget = WebInspector.targetManager.createTarget(WebInspector.UIString("Main"), targetType, connection, null);
console.timeStamp("Main._mainTargetCreated");
this._registerShortcuts();
@@ -317,7 +322,7 @@ WebInspector.Main.prototype = {
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.ReloadInspectedPage, this._reloadInspectedPage, this);
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.EvaluateForTestInFrontend, this._evaluateForTestInFrontend, this);
- if (this._mainTarget.isServiceWorker() || this._mainTarget.isPage())
+ if (this._mainTarget.isServiceWorker() || this._mainTarget.isPage() || this._mainTarget.isJSInspector())
this._mainTarget.runtimeAgent().run();
this._mainTarget.inspectorAgent().enable();

Powered by Google App Engine
This is Rietveld 408576698