third_party/WebKit/Source/devtools/front_end/audits/AuditController.js - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

index 9d16eac865977b496c045bfe54cd7eb218bb5c07..be7afd40c44cab1e3f2b44081d9f31e58dd4179f 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

@@ -71,7 +71,8 @@ WebInspector.AuditController.prototype = {

resultCallback(mainResourceURL, results);

}

- var requests = target.networkLog.requests().slice();

+ var networkLog = WebInspector.NetworkLog.fromTarget(target);

+ var requests = networkLog ? networkLog.requests().slice() : [];

var compositeProgress = new WebInspector.CompositeProgress(this._progress);

var subprogresses = [];

for (var i = 0; i < categories.length; ++i)