third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 36fcba3765cc5b1922d7e09bfcb10bb48f173a16..f1b3451f39c199f8063c9248006bcf7017b3239a 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -211,7 +211,9 @@ WebInspector.NetworkLogView.prototype = {

target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._loadEventFired, this);

target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._domContentLoadedEventFired, this);

}

- target.networkLog.requests().forEach(this._appendRequest.bind(this));

+ var networkLog = WebInspector.NetworkLog.fromTarget(target);

+ if (networkLog)

+ networkLog.requests().forEach(this._appendRequest.bind(this));

/**

@@ -1166,7 +1168,8 @@ WebInspector.NetworkLogView.prototype = {

// Pick provisional load requests.

var requestsToPick = [];

- var requests = frame.target().networkLog.requests();

+ var networkLog = WebInspector.NetworkLog.fromTarget(frame.target());

+ var requests = networkLog ? networkLog.requests() : [];

for (var i = 0; i < requests.length; ++i) {

var request = requests[i];

if (request.loaderId === loaderId)