Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: src/ast/scopes.cc

Issue 2109773004: Move RelocInfo::kNoPosition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@removedead
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.h ('k') | src/ast/variables.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 4c1895ef657ecb27b3a0b8e25075e7b020fe8042..95ab56a46c20978bcb8fc0c204c369b9c0d92623 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -194,8 +194,8 @@ void Scope::SetDefaults(ScopeType scope_type, Scope* outer_scope,
rest_parameter_ = NULL;
rest_index_ = -1;
scope_info_ = scope_info;
- start_position_ = RelocInfo::kNoPosition;
- end_position_ = RelocInfo::kNoPosition;
+ start_position_ = kNoSourcePosition;
+ end_position_ = kNoSourcePosition;
is_hidden_ = false;
if (!scope_info.is_null()) {
scope_calls_eval_ = scope_info->CallsEval();
@@ -455,8 +455,8 @@ Variable* Scope::LookupFunctionVar(const AstRawString* name,
Variable* var = new (zone())
Variable(this, name, mode, Variable::NORMAL, kCreatedInitialized);
VariableProxy* proxy = factory->NewVariableProxy(var);
- VariableDeclaration* declaration = factory->NewVariableDeclaration(
- proxy, mode, this, RelocInfo::kNoPosition);
+ VariableDeclaration* declaration =
+ factory->NewVariableDeclaration(proxy, mode, this, kNoSourcePosition);
DeclareFunctionVar(declaration);
var->AllocateTo(VariableLocation::CONTEXT, index);
return var;
@@ -1016,8 +1016,8 @@ void Scope::CheckScopePositions() {
// A scope is allowed to have invalid positions if it is hidden and has no
// inner scopes
if (!is_hidden() && inner_scopes_.length() == 0) {
- CHECK_NE(RelocInfo::kNoPosition, start_position());
- CHECK_NE(RelocInfo::kNoPosition, end_position());
+ CHECK_NE(kNoSourcePosition, start_position());
+ CHECK_NE(kNoSourcePosition, end_position());
}
for (Scope* scope : inner_scopes_) scope->CheckScopePositions();
}
« no previous file with comments | « src/ast/scopes.h ('k') | src/ast/variables.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698