Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: src/ast/variables.cc

Issue 2109773004: Move RelocInfo::kNoPosition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@removedead
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/scopes.cc ('k') | src/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/variables.h" 5 #include "src/ast/variables.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/globals.h"
9 10
10 namespace v8 { 11 namespace v8 {
11 namespace internal { 12 namespace internal {
12 13
13 // ---------------------------------------------------------------------------- 14 // ----------------------------------------------------------------------------
14 // Implementation Variable. 15 // Implementation Variable.
15 16
16 const char* Variable::Mode2String(VariableMode mode) { 17 const char* Variable::Mode2String(VariableMode mode) {
17 switch (mode) { 18 switch (mode) {
18 case VAR: return "VAR"; 19 case VAR: return "VAR";
19 case CONST_LEGACY: return "CONST_LEGACY"; 20 case CONST_LEGACY: return "CONST_LEGACY";
20 case LET: return "LET"; 21 case LET: return "LET";
21 case CONST: return "CONST"; 22 case CONST: return "CONST";
22 case DYNAMIC: return "DYNAMIC"; 23 case DYNAMIC: return "DYNAMIC";
23 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL"; 24 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL";
24 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL"; 25 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL";
25 case TEMPORARY: return "TEMPORARY"; 26 case TEMPORARY: return "TEMPORARY";
26 } 27 }
27 UNREACHABLE(); 28 UNREACHABLE();
28 return NULL; 29 return NULL;
29 } 30 }
30 31
31
32 Variable::Variable(Scope* scope, const AstRawString* name, VariableMode mode, 32 Variable::Variable(Scope* scope, const AstRawString* name, VariableMode mode,
33 Kind kind, InitializationFlag initialization_flag, 33 Kind kind, InitializationFlag initialization_flag,
34 MaybeAssignedFlag maybe_assigned_flag) 34 MaybeAssignedFlag maybe_assigned_flag)
35 : scope_(scope), 35 : scope_(scope),
36 name_(name), 36 name_(name),
37 mode_(mode), 37 mode_(mode),
38 kind_(kind), 38 kind_(kind),
39 location_(VariableLocation::UNALLOCATED), 39 location_(VariableLocation::UNALLOCATED),
40 index_(-1), 40 index_(-1),
41 initializer_position_(RelocInfo::kNoPosition), 41 initializer_position_(kNoSourcePosition),
42 local_if_not_shadowed_(NULL), 42 local_if_not_shadowed_(NULL),
43 force_context_allocation_(false), 43 force_context_allocation_(false),
44 is_used_(false), 44 is_used_(false),
45 initialization_flag_(initialization_flag), 45 initialization_flag_(initialization_flag),
46 maybe_assigned_(maybe_assigned_flag) { 46 maybe_assigned_(maybe_assigned_flag) {
47 // Var declared variables never need initialization. 47 // Var declared variables never need initialization.
48 DCHECK(!(mode == VAR && initialization_flag == kNeedsInitialization)); 48 DCHECK(!(mode == VAR && initialization_flag == kNeedsInitialization));
49 } 49 }
50 50
51 51
(...skipping 16 matching lines...) Expand all
68 68
69 int Variable::CompareIndex(Variable* const* v, Variable* const* w) { 69 int Variable::CompareIndex(Variable* const* v, Variable* const* w) {
70 int x = (*v)->index(); 70 int x = (*v)->index();
71 int y = (*w)->index(); 71 int y = (*w)->index();
72 // Consider sorting them according to type as well? 72 // Consider sorting them according to type as well?
73 return x - y; 73 return x - y;
74 } 74 }
75 75
76 } // namespace internal 76 } // namespace internal
77 } // namespace v8 77 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast/scopes.cc ('k') | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698