Use source position table in turbofan code.

src/profiler/profiler-listener.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/profiler/profiler-listener.h"
 
 #include "src/deoptimizer.h"
 #include "src/profiler/cpu-profiler.h"
 #include "src/profiler/profile-generator-inl.h"
 #include "src/source-position-table.h"
@@ skipping 70 matching lines @@
                                        SharedFunctionInfo* shared,
                                        Name* script_name, int line,
                                        int column) {
   CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION);
   CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_;
   rec->start = abstract_code->address();
   Script* script = Script::cast(shared->script());
   JITLineInfoTable* line_table = NULL;
   if (script) {
     line_table = new JITLineInfoTable();
-    if (abstract_code->IsCode()) {
-      Code* code = abstract_code->GetCode();
-      int start_position = shared->start_position();
-      int end_position = shared->end_position();
-      if (code->kind() == Code::FUNCTION ||
-          (code->is_optimized_code() && !code->is_turbofanned())) {
-        for (SourcePositionTableIterator it(code->source_position_table());
-             !it.done(); it.Advance()) {
-          int position = it.source_position();
-          // TODO(alph): in case of inlining the position may correspond to an
-          // inlined function source code. Do not collect positions that fall
-          // beyond the function source code. There's however a chance the
-          // inlined function has similar positions but in another script. So
-          // the proper fix is to store script_id in some form along with the
-          // inlined function positions.
-          if (position < start_position || position >= end_position) continue;
-          int line_number = script->GetLineNumber(it.source_position()) + 1;
-          int pc_offset = it.code_offset() + Code::kHeaderSize;
-          line_table->SetPosition(pc_offset, line_number);
-        }
-      } else {
-        for (RelocIterator it(code); !it.done(); it.next()) {
-          RelocInfo* reloc_info = it.rinfo();
-          if (!RelocInfo::IsPosition(reloc_info->rmode())) continue;
-          int position = static_cast<int>(reloc_info->data());
-          // TODO(alph): in case of inlining the position may correspond to an
-          // inlined function source code. Do not collect positions that fall
-          // beyond the function source code. There's however a chance the
-          // inlined function has similar positions but in another script. So
-          // the proper fix is to store script_id in some form along with the
-          // inlined function positions.
-          if (position < start_position || position >= end_position) continue;
-          int pc_offset = static_cast<int>(reloc_info->pc() - code->address());
-          int line_number = script->GetLineNumber(position) + 1;
-          line_table->SetPosition(pc_offset, line_number);
-        }
-      }
-    } else {
-      BytecodeArray* bytecode = abstract_code->GetBytecodeArray();
-      SourcePositionTableIterator it(bytecode->source_position_table());
-      for (; !it.done(); it.Advance()) {
-        int line_number = script->GetLineNumber(it.source_position()) + 1;
-        int pc_offset = it.code_offset() + BytecodeArray::kHeaderSize;
-        line_table->SetPosition(pc_offset, line_number);
-      }
+    int offset = abstract_code->IsCode() ? Code::kHeaderSize
+                                         : BytecodeArray::kHeaderSize;
+    int start_position = shared->start_position();
+    int end_position = shared->end_position();
+    for (SourcePositionTableIterator it(abstract_code->source_position_table());
+         !it.done(); it.Advance()) {
+      int position = it.source_position();
+      // TODO(alph): in case of inlining the position may correspond to an
+      // inlined function source code. Do not collect positions that fall
+      // beyond the function source code. There's however a chance the
+      // inlined function has similar positions but in another script. So
+      // the proper fix is to store script_id in some form along with the
+      // inlined function positions.
+      if (position < start_position || position >= end_position) continue;
+      int line_number = script->GetLineNumber(position) + 1;
+      int pc_offset = it.code_offset() + offset;
+      line_table->SetPosition(pc_offset, line_number);
     }
   }
   rec->entry = NewCodeEntry(
       tag, GetFunctionName(shared->DebugName()), CodeEntry::kEmptyNamePrefix,
       GetName(InferScriptName(script_name, shared)), line, column, line_table,
       abstract_code->instruction_start());
   RecordInliningInfo(rec->entry, abstract_code);
   RecordDeoptInlinedFrames(rec->entry, abstract_code);
   rec->entry->FillFunctionInfo(shared);
   rec->size = abstract_code->ExecutableSize();
@@ skipping 200 matching lines @@
 }
 
 void ProfilerListener::RemoveObserver(CodeEventObserver* observer) {
   auto it = std::find(observers_.begin(), observers_.end(), observer);
   if (it == observers_.end()) return;
   observers_.erase(it);
 }
 
 }  // namespace internal
 }  // namespace v8