Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21095008: Revert the latest set of platform changes. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Revert the latest set of platform changes. Revert "Fix NaCl build." Revert "Revert target arch detection." Revert "Fix typo." Revert "Simplify implementation of Mutex." Revert "Fix for older clang releases that lack __has_extension." Revert "Reland initial bits of "Implement correct OS and CC detection."" TBR=danno@chromium.org,svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -723 lines) Patch
M src/assembler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/checks.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/d8-debug.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/d8-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/debug.cc View 9 chunks +22 lines, -13 lines 0 comments Download
M src/debug-agent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug-agent.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/globals.h View 5 chunks +141 lines, -255 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/isolate.cc View 9 chunks +16 lines, -10 lines 0 comments Download
M src/log-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/mutex.h View 1 chunk +0 lines, -130 lines 0 comments Download
D src/mutex.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M src/optimizing-compiler-thread.h View 3 chunks +8 lines, -2 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform.h View 3 chunks +71 lines, -1 line 0 comments Download
M src/platform-cygwin.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-nullos.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 2 chunks +41 lines, -1 line 0 comments Download
M src/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8threads.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8threads.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M src/win32-headers.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/cctest/test-lock.cc View 3 chunks +31 lines, -2 lines 0 comments Download
D test/cctest/test-mutex.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M test/cctest/test-platform-linux.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M test/cctest/test-platform-nullos.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D test/cctest/test-semaphore.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Benedikt Meurer
7 years, 4 months ago (2013-07-31 07:52:06 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r15976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698