Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2109423002: Revert of [gn] Fix valgrind config (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Fix valgrind config (patchset #1 id:1 of https://codereview.chromium.org/2109403002/ ) Reason for revert: Breaks... Original issue's description: > [gn] Fix valgrind config > > BUG=chromium:474921 > NOTRY=true > NOTREECHECKS=true > TBR=vogelheim@chromium.org, jochen@chromium.org > > Committed: https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291 > Cr-Commit-Position: refs/heads/master@{#37418} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/8d65a3c1ef8b89316db9c73efff3758403a0442d Cr-Commit-Position: refs/heads/master@{#37419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M gni/isolate.gni View 2 chunks +1 line, -6 lines 0 comments Download
M infra/mb/mb_config.pyl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [gn] Fix valgrind config
4 years, 5 months ago (2016-06-30 07:50:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109423002/1
4 years, 5 months ago (2016-06-30 07:50:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 07:50:34 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 07:51:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d65a3c1ef8b89316db9c73efff3758403a0442d
Cr-Commit-Position: refs/heads/master@{#37419}

Powered by Google App Engine
This is Rietveld 408576698