Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: gni/isolate.gni

Issue 2109423002: Revert of [gn] Fix valgrind config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | infra/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/isolate.gni
diff --git a/gni/isolate.gni b/gni/isolate.gni
index c2c025ce0c19f3a020c00ee60db71c1dff007602..e6d166c4603228eba59412cfe309c10d1ab38e40 100644
--- a/gni/isolate.gni
+++ b/gni/isolate.gni
@@ -101,11 +101,6 @@
} else {
use_snapshot = "false"
}
- if (v8_has_valgrind) {
- has_valgrind = "1"
- } else {
- has_valgrind = "0"
- }
# Note, all paths will be rebased in isolate_driver.py to be relative to
# the isolate file.
@@ -137,7 +132,7 @@
"--config-variable",
"gcmole=0",
"--config-variable",
- "has_valgrind=$has_valgrind",
+ "has_valgrind=0",
"--config-variable",
"icu_use_data_file_flag=$icu_use_data_file_flag",
"--config-variable",
« no previous file with comments | « BUILD.gn ('k') | infra/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698