Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: gni/isolate.gni

Issue 2109423002: Revert of [gn] Fix valgrind config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | infra/mb/mb_config.pyl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//third_party/icu/config.gni") 6 import("//third_party/icu/config.gni")
7 import("v8.gni") 7 import("v8.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # Sets the test isolation mode (noop|prepare|check). 10 # Sets the test isolation mode (noop|prepare|check).
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 if (v8_use_external_startup_data) { 94 if (v8_use_external_startup_data) {
95 use_external_startup_data = "1" 95 use_external_startup_data = "1"
96 } else { 96 } else {
97 use_external_startup_data = "0" 97 use_external_startup_data = "0"
98 } 98 }
99 if (v8_use_snapshot) { 99 if (v8_use_snapshot) {
100 use_snapshot = "true" 100 use_snapshot = "true"
101 } else { 101 } else {
102 use_snapshot = "false" 102 use_snapshot = "false"
103 } 103 }
104 if (v8_has_valgrind) {
105 has_valgrind = "1"
106 } else {
107 has_valgrind = "0"
108 }
109 104
110 # Note, all paths will be rebased in isolate_driver.py to be relative to 105 # Note, all paths will be rebased in isolate_driver.py to be relative to
111 # the isolate file. 106 # the isolate file.
112 args = [ 107 args = [
113 v8_test_isolation_mode, 108 v8_test_isolation_mode,
114 "--isolated", 109 "--isolated",
115 rebase_path("$root_out_dir/$name.isolated", root_build_dir), 110 rebase_path("$root_out_dir/$name.isolated", root_build_dir),
116 "--isolate", 111 "--isolate",
117 rebase_path(invoker.isolate, root_build_dir), 112 rebase_path(invoker.isolate, root_build_dir),
118 113
(...skipping 11 matching lines...) Expand all
130 "CONFIGURATION_NAME=$configuration_name", 125 "CONFIGURATION_NAME=$configuration_name",
131 "--config-variable", 126 "--config-variable",
132 "OS=$target_os", 127 "OS=$target_os",
133 "--config-variable", 128 "--config-variable",
134 "asan=$asan", 129 "asan=$asan",
135 "--config-variable", 130 "--config-variable",
136 "cfi_vptr=$cfi_vptr", 131 "cfi_vptr=$cfi_vptr",
137 "--config-variable", 132 "--config-variable",
138 "gcmole=0", 133 "gcmole=0",
139 "--config-variable", 134 "--config-variable",
140 "has_valgrind=$has_valgrind", 135 "has_valgrind=0",
141 "--config-variable", 136 "--config-variable",
142 "icu_use_data_file_flag=$icu_use_data_file_flag", 137 "icu_use_data_file_flag=$icu_use_data_file_flag",
143 "--config-variable", 138 "--config-variable",
144 "msan=$msan", 139 "msan=$msan",
145 "--config-variable", 140 "--config-variable",
146 "tsan=$tsan", 141 "tsan=$tsan",
147 "--config-variable", 142 "--config-variable",
148 "coverage=0", 143 "coverage=0",
149 "--config-variable", 144 "--config-variable",
150 "sanitizer_coverage=0", 145 "sanitizer_coverage=0",
(...skipping 16 matching lines...) Expand all
167 ] 162 ]
168 } else { 163 } else {
169 args += [ 164 args += [
170 "--config-variable", 165 "--config-variable",
171 "msvs_version=0", 166 "msvs_version=0",
172 ] 167 ]
173 } 168 }
174 } 169 }
175 } 170 }
176 } 171 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | infra/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698