Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2109373002: Make maybeConvertNeutral pure virtual (Closed)

Created:
4 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@notreached
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make maybeConvertNeutral pure virtual The body of SVGInterpolationType::maybeConvertNeutral is NOTREACHED() with a comment that the function must be overridden except in a particular condition. This patch changes maybeConvertNeutral to be pure virtual and moves the NOTREACHED implementation into SVGTransformListInterpolationType, which is the only subclass that meets the specified condition. This brings this function into line with the approach taken in SVGInterpolationType::appliedSVGValue and crrev.com/1959993002. Committed: https://crrev.com/09b25d538b2cd35b4c1c482fce20206d254d2736 Cr-Commit-Position: refs/heads/master@{#403116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/animation/SVGInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
suzyh_UTC10 (ex-contributor)
4 years, 5 months ago (2016-06-30 01:14:46 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-06-30 04:31:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109373002/1
4 years, 5 months ago (2016-06-30 06:43:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 08:05:29 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 08:08:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09b25d538b2cd35b4c1c482fce20206d254d2736
Cr-Commit-Position: refs/heads/master@{#403116}

Powered by Google App Engine
This is Rietveld 408576698