Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109333002: Replace ASSERT_NOT_REACHED with NOTREACHED (Closed)

Created:
4 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED ASSERT_NOT_REACHED is deprecated and its usage causes warnings in the check-webkit-style presubmit. This patch replaces ASSERT_NOT_REACHED calls with the recommended replacement, NOTREACHED. Committed: https://crrev.com/6f17c653312de642e47c6c1f05415a2128bcfedd Cr-Commit-Position: refs/heads/master@{#403102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -85 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BasicShapePropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BorderImageLengthBoxPropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/FilterListPropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageListPropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImagePropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageSlicePropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PaintPropertyFunctions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowListPropertyFunctions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Timing.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/TimingCalculations.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableNeutral.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 5 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 2109373002 Patch 1

Messages

Total messages: 15 (6 generated)
suzyh_UTC10 (ex-contributor)
4 years, 5 months ago (2016-06-30 01:04:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109333002/1
4 years, 5 months ago (2016-06-30 01:05:54 UTC) #5
suzyh_UTC10 (ex-contributor)
The relevant check from check-webkit-style: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py?l=114
4 years, 5 months ago (2016-06-30 01:09:24 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 02:28:07 UTC) #8
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-06-30 04:29:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109333002/1
4 years, 5 months ago (2016-06-30 06:35:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 06:40:35 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 06:40:44 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 06:42:43 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6f17c653312de642e47c6c1f05415a2128bcfedd
Cr-Commit-Position: refs/heads/master@{#403102}

Powered by Google App Engine
This is Rietveld 408576698