third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp - Issue 2109373002: Make maybeConvertNeutral pure virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp

Issue 2109373002: Make maybeConvertNeutral pure virtual (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notreached

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp

index 7ccc1fcc3b3317e35dab824c082a64f6de6242d4..2dfd3f56320cf7dc8931832577315ee019a2eb5e 100644

--- a/third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp

@@ -11,13 +11,6 @@

namespace blink {

-InterpolationValue SVGInterpolationType::maybeConvertNeutral(const InterpolationValue&, ConversionCheckers&) const

- NOTREACHED();

- // This function must be overridden, unless maybeConvertSingle is overridden to no longer need it.

- return nullptr;

InterpolationValue SVGInterpolationType::maybeConvertSingle(const PropertySpecificKeyframe& keyframe, const InterpolationEnvironment& environment, const InterpolationValue& underlying, ConversionCheckers& conversionCheckers) const

{

if (keyframe.isNeutral())