third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp - Issue 2109333002: Replace ASSERT_NOT_REACHED with NOTREACHED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

Issue 2109333002: Replace ASSERT_NOT_REACHED with NOTREACHED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

index 74131a557b754448210754e0e2edf49c650ec547..54e47b41ea9de408c83311e72e5b44cb2f56d3fc 100644

--- a/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

@@ -41,7 +41,7 @@ LengthInterpolatedUnit convertToInterpolatedUnit(CSSPrimitiveValue::UnitType uni

switch (unitType) {

case CSSPrimitiveValue::UnitType::Unknown:

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

case CSSPrimitiveValue::UnitType::Pixels:

case CSSPrimitiveValue::UnitType::Number:

case CSSPrimitiveValue::UnitType::UserUnits:

@@ -155,7 +155,7 @@ InterpolationValue SVGLengthInterpolationType::maybeConvertSVGValue(const SVGPro

SVGPropertyBase* SVGLengthInterpolationType::appliedSVGValue(const InterpolableValue& interpolableValue, const NonInterpolableValue*) const

{

- ASSERT_NOT_REACHED();

+ NOTREACHED();

// This function is no longer called, because apply has been overridden.

return nullptr;

}