Cleanup usage of WebApkValidator in notification code

Cleanup usage of WebApkValidator in notification code

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024
Committed: https://crrev.com/82d265d97abff26f8ed3e432c63ee2fcfd456e99
Cr-Commit-Position: refs/heads/master@{#403816}

[pkotwicz, 2016-06-29 03:38:06]

Description was changed from

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent() because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.
- Adds a check for the WebAPK's validity prior to launching a WebAPK from a
  notification.
==========

to

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.
- Adds a check for the WebAPK's validity prior to launching a WebAPK from a
  notification.

BUG=613024
==========

[pkotwicz, 2016-06-29 03:38:06]

pkotwicz@chromium.org changed reviewers:
+ rsesek@chromium.org

[pkotwicz, 2016-06-29 03:40:59]

rsesek@ can you please check whether my reasoning is sound?

https://codereview.chromium.org/2109033002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
(right):

https://codereview.chromium.org/2109033002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:171:
private String queryWebApkPackage(String url) {
I am unsure if WebApkValidator#isValidWebApk() should be checked here.
queryWebApkPackage() is used to determine whether Chrome should delegate
displaying a notification to a WebApk

[Robert Sesek, 2016-06-29 19:19:20]

https://codereview.chromium.org/2109033002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
(right):

https://codereview.chromium.org/2109033002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:171:
private String queryWebApkPackage(String url) {
On 2016/06/29 03:40:59, pkotwicz wrote:
> I am unsure if WebApkValidator#isValidWebApk() should be checked here.
> queryWebApkPackage() is used to determine whether Chrome should delegate
> displaying a notification to a WebApk

Yes, it's probably best to make the API safe by default. Are there instances
where you want to query the package without checking that it's safe to connect
to?

[pkotwicz, 2016-06-30 02:30:01]

Robert can you please take another look?

I have changed WebApkValidator#queryWebApkPackage() and
WebApkValidator#findWebApkPackage() to call WebApkValidator#isValidWebApk()

[Robert Sesek, 2016-06-30 20:19:57]

LGTM

[pkotwicz, 2016-06-30 20:42:05]

Description was changed from

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.
- Adds a check for the WebAPK's validity prior to launching a WebAPK from a
  notification.

BUG=613024
==========

to

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024
==========

[pkotwicz, 2016-06-30 20:42:25]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-06-30 20:42:25]

Xi can you please take a look?

[Xi Han, 2016-07-05 14:38:38]

lgtm

[Peter Beverloo, 2016-07-05 14:40:57]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-07-05 14:40:57]

notifications lgtm

[pkotwicz, 2016-07-05 15:31:12]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-07-05 15:31:13]

yfriedman@ for chrome/android/java OWNERS rubber stamp

[Yaron, 2016-07-05 18:07:43]

https://codereview.chromium.org/2109033002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
(right):

https://codereview.chromium.org/2109033002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:209:
NotificationConstants.EXTRA_NOTIFICATION_INFO_WEBAPK_PACKAGE);
Is this reason can trust the intent extra because it's a non-exported intent so
only we could populate it?

[pkotwicz, 2016-07-05 18:09:39]

https://codereview.chromium.org/2109033002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
(right):

https://codereview.chromium.org/2109033002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:209:
NotificationConstants.EXTRA_NOTIFICATION_INFO_WEBAPK_PACKAGE);
Yes. This is my understanding of how Android works

[Yaron, 2016-07-05 18:15:12]

lgtm

[pkotwicz, 2016-07-05 18:53:05]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-07-05 18:53:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 19:38:59]

Description was changed from

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024
==========

to

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024
==========

[commit-bot: I haz the power, 2016-07-05 19:39:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-05 19:39:01]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-05 19:40:27]

Description was changed from

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024
==========

to

==========
Cleanup usage of WebApkValidator in notification code

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024

Committed: https://crrev.com/82d265d97abff26f8ed3e432c63ee2fcfd456e99
Cr-Commit-Position: refs/heads/master@{#403816}
==========

[commit-bot: I haz the power, 2016-07-05 19:40:28]

Patchset 2 (id:??) landed as
https://crrev.com/82d265d97abff26f8ed3e432c63ee2fcfd456e99
Cr-Commit-Position: refs/heads/master@{#403816}