chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java - Issue 2109033002: Cleanup usage of WebApkValidator in notification code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

Issue 2109033002: Cleanup usage of WebApkValidator in notification code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into notification_platform_bridge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

index 0ef89067e72128f3329f15840d6274b2c5c3692c..e19d9baa274e362943adac86980fed1e634b5c7d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

@@ -184,10 +184,6 @@ public class WebappLauncherActivity extends Activity {

|| webApkPackage == null) {

return false;

}

- if (!WebApkValidator.isValidWebApk(this, webApkPackage)) {

- Log.d(TAG, "%s is not valid WebAPK", webApkPackage);

- return false;

- }

if (!webApkPackage.equals(WebApkValidator.queryWebApkPackage(this, url))) {

Log.d(TAG, "%s is not within scope of %s WebAPK", url, webApkPackage);

return false;