chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java - Issue 2109033002: Cleanup usage of WebApkValidator in notification code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

Issue 2109033002: Cleanup usage of WebApkValidator in notification code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into notification_platform_bridge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

index 5c20a3cd205fbad809b1d98858cb7d211649be22..535f46240996c680e23dfff8bc4e789c3b6eacad 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

@@ -207,8 +207,7 @@ public class NotificationPlatformBridge {

if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_WEBAPK)) {

webApkPackage = intent.getStringExtra(

NotificationConstants.EXTRA_NOTIFICATION_INFO_WEBAPK_PACKAGE);

Yaron 2016/07/05 18:07:43 Is this reason can trust the intent extra because

pkotwicz 2016/07/05 18:09:39 Yes. This is my understanding of how Android works

- if (webApkPackage == null

- || !sInstance.queryWebApkPackage(origin).equals(webApkPackage)) {

+ if (webApkPackage == null) {

webApkPackage = "";

}